chore(test-forks): include sibling BPO forks in --until ranges#2955
Open
spencer-tb wants to merge 1 commit into
Open
chore(test-forks): include sibling BPO forks in --until ranges#2955spencer-tb wants to merge 1 commit into
--until ranges#2955spencer-tb wants to merge 1 commit into
Conversation
spencer-tb
added
C-chore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2955 +/- ##
===================================================
+ Coverage 87.16% 90.50% +3.34%
===================================================
Files 586 535 -51
Lines 35792 32407 -3385
Branches 3364 3011 -353
===================================================
- Hits 31199 29331 -1868
+ Misses 3943 2559 -1384
+ Partials 650 517 -133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
fix/until-includes-bpo-siblings
branch
from
7119c79 to
a5cea90
Compare
marioevz
reviewed
Jun 4, 2026
| single_fork: Set[Type[BaseFork]], | ||
| forks_from: Set[Type[BaseFork]], | ||
| forks_until: Set[Type[BaseFork]], | ||
| transition_forks: bool = True, |
Member
There was a problem hiding this comment.
At the very least we should add a parameter here to disable this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Currently when filling with
--until Amsterdam, we are missing tests that use the BPO3/4/5 test constants.This PR updates
--untilto include them so we don't miss mainnet coverage in releases.The missing tests are denoted below (96 cases):
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_fork_transition_excess_blob_gas_post_blob_genesistests/osaka/eip7918_blob_reserve_price/test_blob_reserve_price_with_bpo_transitions.py::test_reserve_price_at_transition🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.Cute Animal Picture